skip gtest install rules for newer gtest versions #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 1.8.0 the
CMakeLists.txtfile ofgoogletestcontains install rules. Butcatkinmarks the targets withEXCLUDE_FROM_ALLwhich later fails when CMake is trying to install the libraries which haven't been build. The CMake doc explicitly says:While it might be more appropriate to switch to
ExternalProjectthat will likely break user code. Therefore this patch takes the "ugly" way of overriding theinstallfunction to skip the rule for the gtest targets.In a future ROS distro (e.g. M-turtle) when all targeted platforms use the newer googletest version this should probably be updated to use the new
googletestversion which also comes bundled withgooglemockviaExternalProject.The change shouldn't harm Kinetic but would make it possible to build ROS Kinetic on systems which use the new googletest version. So I don't think it should go to a lunar-specific branch.
@ros/ros_team Please review.