add local_setup files

[dirk-thomas]

The existing setup files extend the environment with paths of the workspace they are located in as well as all chained workspaces. The newly added local setup files only extend the environment with paths of a single workspace. This enables the user to specifically select which workspaces to source - independently on how they have been chained during the build.

[jubeira]

I tested the code and it's looking good. I do have a question though; here's what I did to test it (question at the bottom):

• I created two test workspaces, namely bottom_ws and top_ws.
• I built and sourced bottom_ws, and then I built top_ws.
• I sourced top_ws/devel/local_setup.bash and top_ws/devel/setup.bash from two new different terminals.

Then I analyzed the paths using env | grep path -i. Here's the conclusions:

• LD_LIBRARY_PATH, PYTHONPATH, PKG_CONFIG_PATH and CMAKE_PREFIX_PATH look good: for the local script I only see paths below top_ws, and for the regular script I see paths below both top_ws and bottom_ws.
• PATH also looks consistent; the local script doesn't modify the default path, and the regular script adds bottom_ws/devel/bin.
• My question is about ROS_PACKAGE_PATH. For the regular script, the source spaces for top_ws and bottom_ws were added, but for the local script none of them were. Is that expected? Considering the observations above for LD_LIBRARY_PATH, PYTHONPATH, PKG_CONFIG_PATH and CMAKE_PREFIX_PATH I would have expected top_ws source space to be added for the local script to ROS_PACKAGE_PATH.

[dirk-thomas]

My question is about ROS_PACKAGE_PATH. For the regular script, the source spaces for top_ws and bottom_ws were added, but for the local script none of them were. Is that expected? Considering the observations above for LD_LIBRARY_PATH, PYTHONPATH, PKG_CONFIG_PATH and CMAKE_PREFIX_PATH I would have expected top_ws source space to be added for the local script to ROS_PACKAGE_PATH.

This is certainly counter intuitive. The reason for the different behavior is that the other variables are being set by the setup logic generated by catkin where as ROS_PACKAGE_PATH is being set by an environment hook of a specific package. The setup files don't know anything about ROS_PACKAGE_PATH.

I would expect though that the workspace containing the package ros_environment with provides that environment hook to set the ROS_PACKAGE_PATH for that workspace.

[jubeira]

Thanks for the clarification; I don't have any other comments so LGTM!