Enable to output transmission_interface instead of pr2_mechanism_model #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a perfectly good solution to me. It also compiles and passes tests for me locally, so I'll merge it. Thanks for the contribution! |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
collada_to_urdfoutputspr2_mechanism_model/SimpleTransmissionwhen--add_gazebo_descriptionflag is set:https://github.com/ros/collada_urdf/blob/1.12.12/collada_urdf/src/collada_to_urdf.cpp#L483-L490
However, current mainstream of transmission for Gazebo is
transmission_interface/SimpleTransmission:https://github.com/ros-simulation/gazebo_ros_demos/blob/64e9200749567aab9ca2289563eea987fea8cf50/rrbot_description/urdf/rrbot.xacro#L199-L208
This PR enables you to make
collada_to_urdfoutputtransmission_interface/SimpleTransmissionby passing--use_transmission_interface(or-T) flag.This PR doesn't change the current behavior unless that flag is set.