Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noetic] Bump CMake version to avoid CMP0048 warning #67

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 26, 2020

This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@sloretz
Copy link
Contributor

sloretz commented Apr 23, 2020

@scpeters friendly ping

ros/catkin#1052

@scpeters scpeters merged commit 684c93b into ros:master Apr 28, 2020
@scpeters
Copy link
Contributor

sorry for the delay

do you need a new release for this?

@sloretz
Copy link
Contributor

sloretz commented Apr 28, 2020

do you need a new release for this?

No need for a new release. It only affects the dev job.

@dirk-thomas
Copy link
Member

It will affect every from source build using the rosinstall_generator which gets the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants