Add missing rclpy dependency to common_diagnostics to fix rosdoc2 output #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for spotting this :) |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
MrBlenny
added a commit
to Greenroom-Robotics/diagnostics
that referenced
this pull request
Dec 12, 2024
* Add missing rclpy dependency to common_diagnostics to fix rosdoc2 output (ros#402) * Skipping flaky ntp test (ros#409) * skipping flaky ntp test Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * Skipping flaky tests (ros#413) * skipping flaky ntp test Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * also the test_critical_pub skipped Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * oh no .. Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * feat: add publish_values parameter --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: R Kent James <kent@caspia.com> Co-authored-by: Christian Henkel <6976069+ct2034@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, current maintainer of rosdoc2 here. I enjoyed the talk on diagnostics at ROSCON 2024, so I thought I would try to figure out why some documentation is missing. Turns out to be pretty straightforward: a missing dependency.
You should see at https://docs.ros.org/en/rolling/p/diagnostic_common_diagnostics/diagnostic_common_diagnostics.html that all of the submodule python documentation is missing. This PR fixes it in my fork.