Skip to content

Conversation

@christophfroehlich
Copy link
Contributor

the ros2 branch does not compile on rolling-testing because
ament/ament_cmake#583
got merged, before
ament/ament_cmake#572
got synced.

Fixes ros-controls/ros2_control#2272

@mergify mergify bot added the ros2 PR tackling a ROS2 branch label May 24, 2025
Copy link

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding!

@destogl
Copy link

destogl commented May 26, 2025

Very nice!

@ct2034
Copy link
Collaborator

ct2034 commented May 26, 2025

Thanks @christophfroehlich :)

@ct2034 ct2034 merged commit f516165 into ros:ros2 May 26, 2025
13 checks passed
ct2034 pushed a commit to ct2034/diagnostics that referenced this pull request May 26, 2025
@ct2034
Copy link
Collaborator

ct2034 commented May 26, 2025

💚 All backports created successfully

Status Branch Result
ros2-kilted

Questions ?

Please refer to the Backport tool documentation

mergify bot added a commit that referenced this pull request May 26, 2025
[ros2-kilted] Use target_link_libraries instead of ament_target_dependencies (#507)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ros2 PR tackling a ROS2 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI build job rolling/source failed!

5 participants