Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setuptools instead of distutils #17

Merged
merged 2 commits into from
Jan 25, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 25, 2020

On Debian Buster and Ubuntu Focal distutils has been split to a separate package. With ros/catkin#1048 catkin will prefer to use setuptools instead of distutils. This PR switches to setuptools to match catkin's preference. It uses conditional dependencies so it still works when ROS_PYTHON_VERSION is 2 to enable the target branch to be released to earlier ROS distros than Noetic.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz requested a review from dirk-thomas January 25, 2020 01:37
@sloretz sloretz self-assigned this Jan 25, 2020
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@dirk-thomas
Copy link
Member

This should target a to-be-created kinetic-devel branch.

@sloretz sloretz changed the base branch from groovy-devel to kinetic-devel January 25, 2020 01:56
@dirk-thomas dirk-thomas merged commit 6f25650 into ros:kinetic-devel Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants