Missing module __init__ in package containing messages and catkin_python_setup() #34
Comments
|
@wjwwood this might be the same problem you're having |
|
The problem why this happens in your case is that the message generation happens for the package name I am not sure if and how this can be fixed in genmsg/catkin. I will have to look into it a bit more. [The "right" solution would probably be to only have a Python package which matches the package name and if multiple package names are necessary split the ROS package into multiple ones.] |
|
Okay, cool. The main frustration is that it's such a subtle failure—might be something to try to warn the user about at build time, or even refuse to build. |
….py when signaling that an __init__.py file is installed to genmsg/dynamic_reconfigure (ros/genmsg#34)
ghost
assigned …from project name (ros/genmsg#34)
|
I have fixed the issue in the affected packages (catkin, genmsg, dynamic_reconfigure). As soon as these packages are released (next days) you should revert your workaround (clearpathrobotics/clearpath_base@e0b4510) and add a versioned dependency to ensure that you depend on the latest version of the packages. |
|
Hi Dirk—sorry to trouble you. How do I declare a versioned dependency? I checked out the package.xml page, and didn't see any mention of it. Alternatively, is there any harm in just leaving it in? I can always zap it in a few weeks when the coast is definitely clear. |
|
It is defined in the REP: |
|
I am not sure if the install rules will collide? Since your package will rely on a specific minimum version of another package it should declare that. Nothing prevents a user from having an older version of e.g. catkin/genmsg installed but updated your package. |
|
Hmm, okay. I believe I've made the correct changes in the following branch: https://github.com/clearpathrobotics/clearpath_base/compare/genmsg_workaround_removal Once you've released catkin 0.5.74 and genmsg 0.4.23, then I'll merge that branch and cut a new release of clearpath_base. |
|
The changes on the branch look good - I will comment as soon as the packages are released. |
|
The packages have been released so you can go ahead and also release your packages. |
|
Package is released and works great, thanks. I appreciate the hand-holding. |
Changes since 0.4.20: 0.5.3 (2014-07-10) ------------------ * escape messages to avoid CMake warning (`#49 <https://github.com/ros/genmsg/issues/49>`_) 0.5.2 (2014-05-07) ------------------ * refactor to generate pkg-msg-paths.cmake via configure_file() instead of empy (`#43 <https://github.com/ros/genmsg/issues/43>`_) * fix python 3 compatibility (`#45 <https://github.com/ros/genmsg/issues/45>`_) * remove debug message introduced in 0.5.1 (`#42 <https://github.com/ros/genmsg/issues/42>`_) 0.5.1 (2014-03-04) ------------------ * add check for changed message dependencies (`#41 <https://github.com/ros/genmsg/issues/41>`_) 0.5.0 (2014-02-25) ------------------ * remove usage of debug_message() (`#40 <https://github.com/ros/genmsg/issues/40>`_) 0.4.24 (2014-01-07) ------------------- * python 3 compatibility (`#36 <https://github.com/ros/genmsg/issues/36>`_, `#37 <https://github.com/ros/genmsg/issues/37>`_) * add support for ROS_LANG_DISABLE env variable (`ros/ros#39 <https://github.com/ros/ros/issues/39>`_) * fix installation of __init__.py from devel space (`#38 <https://github.com/ros/genmsg/issues/38>`_) 0.4.23 (2013-09-17) ------------------- * fix installation of __init__.py file for packages where name differs from project name (`#34 <https://github.com/ros/genmsg/issues/34>`_) * rename variable 'config' to not collide with global variable (`#33 <https://github.com/ros/genmsg/issues/33>`_) * fix service files variable to only contain package relative paths (`#32 <https://github.com/ros/genmsg/issues/32>`_) 0.4.22 (2013-08-21) ------------------- * make genmsg relocatable (`ros/catkin#490 <https://github.com/ros/catkin/issues/490>`_) * add warning in case generate_messages() is invoked without any messages and services (`#31 <https://github.com/ros/genmsg/issues/31>`_) * check if files have been generated before trying to install them (`#31 <https://github.com/ros/genmsg/issues/31>`_) 0.4.21 (2013-07-03) ------------------- * check for CATKIN_ENABLE_TESTING to enable configure without tests
Pretty sure this is a repeat of issue #10.
My package works fine in devel space, when I go to install it, I get this:
The
__init__.pyfile in the package root get compiled, but it never gets installed.On a hunch, I finally removed
catkin_python_setup(), and then it does the right thing and installs the__init__.pyfile:I know this is not an ideally-named package (or API design), but it's this way to maintain consistency with some historical decisions. The package source is here:
https://github.com/clearpathrobotics/clearpath_base
For now, I'm going to just work around this by manually installing the file, but it was a pretty nasty bug to figure out.
For interested parties, here's the workaround:
The text was updated successfully, but these errors were encountered: