Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf2 has a missing build_export_depend on tf2_geometry_msgs #493

Closed
stertingen opened this issue Jan 19, 2021 · 1 comment
Closed

tf2 has a missing build_export_depend on tf2_geometry_msgs #493

stertingen opened this issue Jan 19, 2021 · 1 comment

Comments

@stertingen
Copy link

The package tf2 includes a header from tf2_geometry_msgs (https://github.com/ros/geometry2/blob/noetic-devel/tf2/include/tf2/impl/utils.h#L18) but does not declare a build export dependency in package.xml or CMakeLists.txt.

Since tf2_geometry_msgs also depends on tf2, we have a circular dependency here. Unfortunately, I don't know how to fix this.

@stertingen
Copy link
Author

Duplicate of #275

ooeygui pushed a commit to ms-iot/geometry2 that referenced this issue Oct 12, 2022
…#493)

* Install includes to include/${PROJECT_NAME} and use modern CMake

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Remove dependency on eigen3_cmake_module

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Undo whitespace change

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Remove extra newline

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Remove duplicate add_library call

* Keep making old style CMake variables

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Update test dependencies

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Alphabetize

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Include dirs and libs for static_transform_broadcaster_node

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Use Eigen3::Eigen when available, else Eigen3_INCLUDE_DIRS

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* target_include_directories(... PRIVATE

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Fix indentation

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant