Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated log macro calls #279

Closed
wants to merge 1 commit into from

Conversation

racko
Copy link
Contributor

@racko racko commented Jan 4, 2018

Fixes #271

@tfoote tfoote added the blocked label Jan 5, 2018
@tfoote
Copy link
Member

tfoote commented Jan 5, 2018

For background this is being held until we fork development off of indigo

@mikaelarguedas
Copy link
Member

If you want to support recent console_bridge without/before branching out, several core packages support various console_bridge versions like this:
ros/class_loader#52
Some packages in ROS undefined some deprecated macros as they collide so reling on the existence of the non prefixed macros is fragile. We worked around it bu using pure console_bridge calls: ros/class_loader#66 was necessary as well

@tfoote
Copy link
Member

tfoote commented Mar 22, 2018

Merged into melodic-devel (this cannot be ported back to kinetic or earlier due to the new API only being available in console_bridge 0.3 which is not available on Jessie for Kinetic.

@tfoote tfoote closed this Mar 22, 2018
@tfoote
Copy link
Member

tfoote commented Apr 27, 2018

We haven't created a development fork for lunar and aren't planning to make one. Since 18.04 isn't a targeted platform I'd recommend just using the melodic branch.

seanyen pushed a commit to ms-iot/geometry2 that referenced this pull request Aug 18, 2020
…os#283)

* Moved unique_lock of messages_mutex_ to guarantee msg_it points to the correct element in messages_

Co-authored-by: Martin Ganeff <mganeff@lely.com>

Co-authored-by: Martin Ganeff <mganeff@lely.com>
seanyen pushed a commit to ms-iot/geometry2 that referenced this pull request Mar 22, 2021
* Moved unique_lock of messages_mutex_ to guarantee msg_it points to the correct element in messages_

Co-authored-by: Martin Ganeff <mganeff@lely.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants