Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf2_ros::Buffer: canTransform can now deal with timeouts smaller than… #286

Merged
merged 3 commits into from
Feb 21, 2018

Conversation

cwecht
Copy link
Contributor

@cwecht cwecht commented Feb 19, 2018

… 10ms by using the hunderdth of the timeout for sleeping

Resolves #281 .

Christopher Wecht added 2 commits February 19, 2018 17:11
@cwecht
Copy link
Contributor Author

cwecht commented Feb 19, 2018

hm, is it possible that tf2_ros.rosunit-transform_listener_time_reset_test/time_backward is a bit flaky?

@tfoote
Copy link
Member

tfoote commented Feb 21, 2018

Yeah, the test is flaky (It's the last of #129) I hoped that it was resolved in #283 I'll reopen that.

Can you move the magic number to a const at the top and adjust it to be 100th as we talked about? Something like: const double CAN_TRANSFORM_POLLING_SCALE = 0.01; Polling 1000 times before the timeout seems to be expensive.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iterations.

@tfoote tfoote merged commit c24de7f into ros:indigo-devel Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants