Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate rosconsole #24

Merged
merged 1 commit into from
May 21, 2018
Merged

separate rosconsole #24

merged 1 commit into from
May 21, 2018

Conversation

dirk-thomas
Copy link
Member

See ros/rosdistro#17919.

Separating rosconsole and moving pluginlib and class_loader from "ros_base" to "ros_core".

@dirk-thomas dirk-thomas requested a review from clalancette May 21, 2018 15:43
@dirk-thomas dirk-thomas mentioned this pull request May 21, 2018
Closed
12 tasks
@dirk-thomas
Copy link
Member Author

@mikaelarguedas FYI since it affect the "grouping" of pluginlib and class_loader.

mikaelarguedas
mikaelarguedas approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikaelarguedas mikaelarguedas merged commit 890ad6d into melodic-devel May 21, 2018
@mikaelarguedas mikaelarguedas deleted the extract_rosconsole branch May 21, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirk-thomas @clalancette @mikaelarguedas