Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[noetic][pluginlib] declare specific boost dependencies #171

Merged
merged 4 commits into from
May 22, 2020
Merged

[noetic][pluginlib] declare specific boost dependencies #171

merged 4 commits into from
May 22, 2020

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Jan 26, 2020 •
edited
Loading

May be worth targeting to a noetic-devel to not impact released packages on other distributions

related to ros/ros_comm#1871

@mikaelarguedas
[pluginlib] declare specific boost dependencies
6beeab2 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
caioaamaral
caioaamaral reviewed Jan 26, 2020
View reviewed changes
pluginlib/package.xml Outdated Show resolved Hide resolved
@mikaelarguedas mikaelarguedas changed the title [pluginlib] declare specific boost dependencies [noetic][pluginlib] declare specific boost dependencies Jan 26, 2020
@mikaelarguedas
convert depend in build_export_depend as pluginlib is header only
4dccaf1 
actually keep them as build_depend and build_export_depend as they are "find_package(REQUIRED) in the CMakeLists of this package"

remove libboost-system as it doesnt seem to be imported/used anywhere
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@sloretz
Copy link
Contributor

sloretz commented Feb 14, 2020

@ros-pull-request-builder retest this please

1 similar comment
@sloretz
Copy link
Contributor

sloretz commented Feb 14, 2020

@ros-pull-request-builder retest this please

@sloretz
Copy link
Contributor

sloretz commented Feb 14, 2020

CI looks ok, just a CMP0048 warning which could be fix in a different PR: http://wiki.ros.org/noetic/Migration#Increase_required_CMake_version_to_avoid_author_warning

@sloretz
Copy link
Contributor

sloretz commented Feb 14, 2020

Opened #173 to fix Noetic pluginlib PR jobs

nuclearsandwich added a commit that referenced this pull request Feb 14, 2020
@nuclearsandwich
Update CMake minimum version to address CMP0048 warning.
2084b46 
Hat tip to Shane whose comment in another PR diagnosed the warning:
#171 (comment)

Melodic's currently supported platforms, Stretch and Bionic, use CMake
3.7.2 and 3.10.2 respectively so this change can target melodic-devel.
@nuclearsandwich nuclearsandwich mentioned this pull request Feb 14, 2020
Closed
@nuclearsandwich
Copy link
Member

@ros-pull-request-builder retest this please

@mikaelarguedas
add libboost-dev to allow filesystem removal in the future
b891134 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas mentioned this pull request Mar 3, 2020
Merged
@sloretz
Copy link
Contributor

sloretz commented Apr 23, 2020

@nuclearsandwich friendly ping. Looks like both Melodic and Noetic PR jobs passed 🎉

@sloretz
Copy link
Contributor

sloretz commented May 19, 2020

@nuclearsandwich friendly ping

@sloretz sloretz changed the base branch from melodic-devel to noetic-devel May 21, 2020 15:01
@sloretz
Copy link
Contributor

sloretz commented May 22, 2020

Results of a Noetic prerelease test

mkdir -p /tmp/prerelease_job
cd /tmp/prerelease_job
generate_prerelease_script.py \
  https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml \
  noetic default ubuntu focal amd64 \
  --custom-repo \
    pluginlib__custom-1:git:https://github.com/mikaelarguedas/pluginlib.git:restrict-boost-deps \
  --level 7 \
  --output-dir ./ \
  --exclude-pkg capabilities fkie_message_filters

Plus edited overlay to include at-wat/neonavigation#497

ws_overlay/test_results/controller_manager_tests/rostest-test_controller_manager_scripts.xml: 2 tests, 1 errors, 0 failures, 0 skipped
ws_overlay/test_results/geodesy/nosetests-tests.test_wu_point.py.xml: 5 tests, 2 errors, 0 failures, 0 skipped
ws_overlay/test_results/rosmsg/nosetests-test.xml: 31 tests, 3 errors, 4 failures, 0 skipped
ws_overlay/test_results/stage_ros/rostest-test_intensity_test.xml: 1 tests, 0 errors, 1 failures, 0 skipped
ws_overlay/test_results/ypspur_ros/rosunit-test_joint_trajectory.xml: 2 tests, 0 errors, 2 failures, 0 skipped
Summary: 2394 tests, 6 errors, 7 failures, 0 skipped
  • controller_manager_tests/rostest-test_controller_manager_scripts.xml: 2 tests, 1 errors, 0 failures, 0 skipped
  • geodesy/nosetests-tests.test_wu_point.py.xml: 5 tests, 2 errors, 0 failures, 0 skipped
    • Python 3 incompatibility; missing xrange
  • rosmsg/nosetests-test.xml: 31 tests, 3 errors, 4 failures, 0 skipped
    • resource not found test_rosmaster, seems like rosmsg tests are expecting source repo layout?
  • stage_ros/rostest-test_intensity_test.xml: 1 tests, 0 errors, 1 failures, 0 skipped
  • ypspur_ros/rosunit-test_joint_trajectory.xml: 2 tests, 0 errors, 2 failures, 0 skipped

So looking pretty good. The controller_manager_tests failure is the only one I want to check out.

@sloretz
Copy link
Contributor

sloretz commented May 22, 2020

I've run the controller_manager_tests a couple times by re-running ./prerelease_build_overlay.sh and haven't seen the failures again. I'm going to assume it's a flaky test, and none of the other test results seem to be the result of this PR.

@nuclearsandwich I'm going to use the permission you gave me at the start of the day to merge and release.

@sloretz sloretz merged commit d941fa5 into ros:noetic-devel May 22, 2020
@mikaelarguedas mikaelarguedas deleted the restrict-boost-deps branch May 22, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caioaamaral caioaamaral caioaamaral left review comments

@sloretz sloretz sloretz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikaelarguedas @sloretz @nuclearsandwich @caioaamaral