Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wShadow compile warning #250

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix wShadow compile warning #250

merged 1 commit into from
Oct 27, 2023

Conversation

SteveMacenski
Copy link
Member

it is defined on L479 and then again in the for loop. Renamed the for look items so that it doesn't compile with warnings turned to errors with -wshadow enabled

@SteveMacenski
Copy link
Member Author

I see there is both a rolling and a ros2 branch, so I selected Rolling but I wasn't sure which

@SteveMacenski SteveMacenski mentioned this pull request Oct 26, 2023
Closed
@clalancette
Copy link
Contributor

I see there is both a rolling and a ros2 branch, so I selected Rolling but I wasn't sure which

Yeah, rolling is correct. One of these days we'll make that clear.

clalancette
clalancette approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good call. I'll run CI on it next.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@SteveMacenski
Copy link
Member Author

Sweet! The ticket I linked above can also be closed when this is merged. Found out after I ran into it Ryan reported it as well

@clalancette clalancette merged commit 16ae61c into ros:rolling Oct 27, 2023
1 check passed
@SteveMacenski SteveMacenski deleted the patch-1 branch October 27, 2023 18:56
@Ryanf55 Ryanf55 mentioned this pull request Oct 27, 2023
Closed
Wiktor-99 pushed a commit to Wiktor-99/pluginlib that referenced this pull request Nov 19, 2024
@SteveMacenski @Wiktor-99
Fix wShadow compile warning (ros#250)
39855d7
Wiktor-99 pushed a commit to Wiktor-99/pluginlib that referenced this pull request Nov 19, 2024
@SteveMacenski @Wiktor-99
Fix wShadow compile warning (ros#250)
50d8032 
Signed-off-by: Wiktor Bajor <wiktorbajor1@gmail.com>
@Wiktor-99 Wiktor-99 mentioned this pull request Dec 12, 2024
Merged
clalancette pushed a commit that referenced this pull request Dec 13, 2024
@Wiktor-99 @SteveMacenski
Fix wShadow compile warning (#250) (#266)
5b52801 
Signed-off-by: Wiktor Bajor <wiktorbajor1@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveMacenski @clalancette