Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rospy.log*_throttle (and _once) do not accept (kw)args #1222

Closed
gavanderhoorn opened this issue Nov 8, 2017 · 2 comments
Closed

rospy.log*_throttle (and _once) do not accept (kw)args #1222

gavanderhoorn opened this issue Nov 8, 2017 · 2 comments

Comments

@gavanderhoorn
Copy link
Contributor

gavanderhoorn commented Nov 8, 2017

It would appear the rospy.logX_throttle(..) and rospy.logX_once(..) methods introduced in #812 and #1041 do not accept args or keyword args like the regular logX(..) methods do.

This means that instead of rospy.loginfo("fmt", arg0, arg1, argN) they have to be passed a bare string (ie: rospy.loginfo_throttle(1.0, "some string")).

This can be worked around by using str.format(..) itself, but symmetry with the base logX(..) methods is lost this way.

Was this intentional, or an oversight?

@dirk-thomas
Copy link
Member

@wkentaro Maybe you can answer the question and/or provide a follow up PR to align the signatures.

mgrrx added a commit to magazino/ros_comm that referenced this issue Jan 1, 2018
mgrrx added a commit to magazino/ros_comm that referenced this issue Sep 21, 2018
mgrrx added a commit to magazino/ros_comm that referenced this issue Sep 21, 2018
dirk-thomas pushed a commit that referenced this issue Feb 10, 2020
* Added args and kwargs to rospy.log*

Implements #1222

* Exposed logger_name

* Fixup
@dirk-thomas
Copy link
Member

Addressed by #1290.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants