-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paramtest fails for parameters with valid None or empty string values #2053
Comments
lewkoo
added a commit
to lewkoo/ros_comm
that referenced
this issue
Sep 23, 2020
lewkoo
added a commit
to lewkoo/ros_comm
that referenced
this issue
Oct 15, 2020
lewkoo
added a commit
to lewkoo/ros_comm
that referenced
this issue
Oct 15, 2020
dirk-thomas
pushed a commit
that referenced
this issue
Oct 15, 2020
jacobperron
pushed a commit
that referenced
this issue
Oct 16, 2020
jacobperron
pushed a commit
that referenced
this issue
Oct 22, 2020
jacobperron
pushed a commit
that referenced
this issue
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What did you try?
Tried to test a parameter with an empty value using
paramtest
node.What did you observe?
Test timed out
What did you expect?
Test succeeded
All said?
When using paramtest node to test existence / correctness of a value of a parameter in a parameter server, the test will not finish for parameters which have a valid value of None or are just empty.
In
paramtest
the condition is specified aswhile not param_obtained
but it will also evaluate to True if param_obtained is an empty string and sometimes that is a correct parameter value.Solution: Replace
while not param_obtained
withwhile param_obtained is None
.The text was updated successfully, but these errors were encountered: