Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose rate-control-topic and rate-control-max-delay args to command … #1015

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

jihoonl
Copy link

@jihoonl jihoonl commented Mar 9, 2017

…line tool

To use #947 with command line tool.

jihoonl@whoola:~$ rosbag play --help
Usage: rosbag play BAGFILE1 [BAGFILE2 BAGFILE3 ...]

Play back the contents of one or more bag files in a time-synchronized
fashion.

Options:
  -h, --help            show this help message and exit
  -p PREFIX, --prefix=PREFIX
                        prefix all output topics
  -q, --quiet           suppress console output
  -i, --immediate       play back all messages without waiting
  --pause               start in paused mode
  --queue=SIZE          use an outgoing queue of size SIZE (defaults to 100)
  --clock               publish the clock time
  --hz=HZ               use a frequency of HZ when publishing clock time
                        (default: 100)
  -d SEC, --delay=SEC   sleep SEC seconds after every advertise call (to allow
                        subscribers to connect)
  -r FACTOR, --rate=FACTOR
                        multiply the publish rate by FACTOR
  -s SEC, --start=SEC   start SEC seconds into the bag files
  -u SEC, --duration=SEC
                        play only SEC seconds from the bag files
  --skip-empty=SEC      skip regions in the bag with no messages for more than
                        SEC seconds
  -l, --loop            loop playback
  -k, --keep-alive      keep alive past end of bag (useful for publishing
                        latched topics)
  --try-future-version  still try to open a bag file, even if the version
                        number is not known to the player
  --topics              topics to play back
  --pause-topics        topics to pause on during playback
  --bags=BAGS           bags files to play back from
  --wait-for-subscribers
                        wait for at least one subscriber on each topic before
                        publishing
  --rate-control-topic=RATE_CONTROL_TOPIC
                        watch the given topic, and if the last publish was
                        more than <rate-control-max-delay> ago, wait until the
                        topic publishes again to continue playback
  --rate-control-max-delay=RATE_CONTROL_MAX_DELAY
                        maximum time difference from <rate-control-topic>
                        before pausing
jihoonl@whoola:~$ 

@dirk-thomas
Copy link
Member

@ros-pull-request-builder retest this please

@dirk-thomas
Copy link
Member

Thank you for the patch!

@dirk-thomas dirk-thomas merged commit 5d79c24 into ros:lunar-devel Mar 14, 2017

if options.rate_control_max_delay:
cmd.extend(['--rate-control-max-delay', str(options.rate_control_max_delay)])

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoonl Inserting this between --bags and args broke the feature to pass topics or pausing topics. See #1156 for the necessary fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants