Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport transport_tcp bugfix to Kinetic #1069

Closed
wants to merge 2 commits into from
Closed

backport transport_tcp bugfix to Kinetic #1069

wants to merge 2 commits into from

Conversation

andyli
Copy link

@andyli andyli commented May 29, 2017 •
edited
Loading

Here I cherrypicked the fix in #1050 and applied it to the kinetic-devel branch.
Tested on my machine in WSL:

rosrun turtlesim turtle_teleop_key
rostopic echo /turtle1/cmd_vel

Everything works as expected.

For people who want to get this now:

git clone -b transport_tcp_kinetic https://github.com/andyli/ros_comm.git
ln -s /abs/path/to/ros_comm ~/catkin_ws
cd ~/catkin_ws
catkin_make
catkin_make install

# you may add this line to ~/.bashrc
source ~/catkin_ws/devel/setup.bash

bxwllzz and others added 2 commits May 29, 2017 16:21
@bxwllzz @andyli
Fix bug in transport_tcp (ros#1050)
e9c90d2 
* Fix bug in transport_tcp

It assumes that the `connect` method of non-blocking scoket should return -1 and `last_socket_error()` should return `ROS_SOCKETS_ASYNCHRONOUS_CONNECT_RETURN`(=`EINPROGRESS`). 
But a non-blocking `connect` can return 0 when TCP connection to 127.0.0.1 (localhost).
[http://stackoverflow.com/questions/14027326/can-connect-return-0-with-non-blocing-socket](http://stackoverflow.com/questions/14027326/can-connect-return-0-with-non-blocing-socket)

* Modify code format

Modify code format
@andyli
update changelog
cb7f965
@dirk-thomas
Copy link
Member

Thank you. But all backports will happen before the next Kinetic release in a single pull request (similar to e.g. #1008). Therefore I will close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyli @dirk-thomas @bxwllzz