Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoids buffer overflow in xmlrpcpp if fd > 1024 #1113

Closed
wants to merge 1 commit into from
Closed

Avoids buffer overflow in xmlrpcpp if fd > 1024 #1113

wants to merge 1 commit into from

Commits on Aug 9, 2017

  1. Avoids buffer overflow in xmlrpcpp if fd > 1024 

    A temporary fix to avoid buffer overflow in XmlRpcDispatch, since select() only works for file descriptors < FD_SETSIZE (1024). The real solution is to switch to poll as in ros#833, but since that PR was reverted, this avoids catastrophic failure. It throws instead of being silent, since (a) this behaviour is no less intrusive than a buffer overflow, and (b) returning an error was handled silently, and just looked like ros comm not being connected.
    @kmactavish
    kmactavish committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    9cad0e5 View commit details
    Browse the repository at this point in the history