Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rostopic hz and bw in Python 3 #1126

Merged
merged 7 commits into from
Aug 15, 2017
Merged

Fix rostopic hz and bw in Python 3 #1126

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c2d32b
string.atoi is not present in Python3, just use int(x)
kartikmohta Aug 9, 2017
4c74df9
rostopic bw: set default value of window_size arg to -1 instead of None
kartikmohta Aug 12, 2017
86a2a29
Check for window_size < 0 when constructing ROSTopicBandwidth object
kartikmohta Aug 12, 2017
3255330
Revert "Check for window_size < 0 when constructing ROSTopicBandwidth…
kartikmohta Aug 14, 2017
37d22bb
Revert "rostopic bw: set default value of window_size arg to -1 inste…
kartikmohta Aug 14, 2017
fa21976
Check for argument != None before calling int(options.window_size)
kartikmohta Aug 14, 2017
0abcba9
Properly check for options.window_size != None before converting to int
kartikmohta Aug 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions tools/rostopic/src/rostopic/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,11 +1488,7 @@ def _rostopic_cmd_hz(argv):
if len(args) == 0:
parser.error("topic must be specified")
try:
if options.window_size != -1:
import string
window_size = string.atoi(options.window_size)
else:
window_size = options.window_size
window_size = int(options.window_size)
except:
parser.error("window size must be an integer")

Expand Down Expand Up @@ -1540,11 +1536,7 @@ def _rostopic_cmd_bw(argv=sys.argv):
if len(args) > 1:
parser.error("you may only specify one input topic")
try:
if options.window_size:
import string
window_size = string.atoi(options.window_size)
else:
window_size = options.window_size
window_size = int(options.window_size) if options.window_size else None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will set the variable to None in case the option is 0. So this should check for None explicitly:

int(options.window_size) if options.window_size is not None else None

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does a window_size of 0 even make sense for rostopic bw? Just falling back to the default might be better in that case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is what the user asked for why do something else? This magic would then also need to be documented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user is always right 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user is always right

Oh no, but we give him what was asked for anyway 😉 🔥

except:
parser.error("window size must be an integer")
topic = rosgraph.names.script_resolve_name('rostopic', args[0])
Expand Down