Fix rosbag API for Python 3 #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually don't see the need to involve @nstiurca, as my branch is not forked from his branch and supersedes his changes. Nevertheless I opened nstiurca#1 if it helps the process. |
|
I accidentally assumed your patch was addressing the remaining comment on #1048 but relied on other parts of the patch. Now I see that this patch is "complete" on its own. I will merge this one as is and close the previous ticket. Thanks and sorry for the extra effort. |
|
Thanks for merging. I guess my wording in the first comment was missleading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1047
This commit addresses the remaining issues of #1048.