Enabled rosbag::Bag move operations if compiler support is available #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Oct 17, 2017
| Bag& operator=(Bag&& other) { | ||
| swap(other); | ||
| return *this; | ||
| } |
There was a problem hiding this comment.
Please keep the implementation of these methods in the cpp file even though they are short.
racko
force-pushed
the
rosbag_move_operations_if_possible
branch
from
f787b59 to
c057ffb
Compare
|
Updated |
racko
force-pushed
the
rosbag_move_operations_if_possible
branch
from
c057ffb to
5b55572
Compare
|
Thank you for the patch. |
This was referenced Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.