ROSBagException should call the base constructor #1210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
requested changes
Oct 31, 2017
| @@ -75,24 +75,19 @@ class ROSBagException(Exception): | |||
| """ | |||
| Base class for exceptions in rosbag. | |||
| """ | |||
| def __init__(self, value): | |||
| self.value = value | |||
There was a problem hiding this comment.
Removing value will effectively change the public API of this exception. Therefore I don't think this PR can be applied as-is since it would break compatibility with existing code.
Maybe the constructor should be kept and invoke the parent constructor explicitly? If the parent constructor is being called with value the custom __str__ implementation might still be obsolete.
dirk-thomas
pushed a commit
that referenced
this pull request
Apr 1, 2019
* test_rosbag/test_bag.py: test, if rosbag exception can be pickled * rosbag/bag.py: rosbag exceptions can now be unpickled * pep8
|
Superseded by #1652. |
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
* test_rosbag/test_bag.py: test, if rosbag exception can be pickled * rosbag/bag.py: rosbag exceptions can now be unpickled * pep8
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 4, 2020
* test_rosbag/test_bag.py: test, if rosbag exception can be pickled * rosbag/bag.py: rosbag exceptions can now be unpickled * pep8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1209