Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use namespaced macros instead of deprecated macros #1239

Merged

Conversation

mikaelarguedas
Copy link
Member

The rest of rosbag uses the new namespaced macros.
Given that the old console bridge macros are undefined in:

#if defined logDebug
# undef logDebug
#endif
#if defined logInform
# undef logInform
#endif
#if defined logWarn
# undef logWarn
#endif
#if defined logError
# undef logError
#endif

The rest of the code base needs to use the new ones

@mikepurvis
Copy link
Member

LGTM.

@mikepurvis mikepurvis merged commit f7c7b3c into ros:lunar-devel Nov 19, 2017
@mikaelarguedas mikaelarguedas deleted the namespaced_console_bridge_macros branch November 19, 2017 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants