Test and fix uninitialized data in XmlRpcClient #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mikepurvis
reviewed
Dec 12, 2017
| // Check that state machine is in the correct state after getting the header. | ||
| EXPECT_EQ(XmlRpcClient::NO_CONNECTION, a._connectionState); | ||
| EXPECT_EQ(XmlRpcClient::WRITE_REQUEST, a._connectionState); |
There was a problem hiding this comment.
The original logic was falling into the not connected state during this test because _sendAttempts was not correctly initialized to zero. This caused the client to immediately fail instead of attempting to retry.
By fixing the initialization, the client now correctly transitions to the write request state if the header read fails on the first attempt. I've updated this test and the others to correctly capture the retry behavior and the failure if readHeader fails again on a second attempt.
|
Thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test problems that were exposed by uninitialized memory, properly initialize memory and add tests for proper memory initialization.
Since uninitialized memory was causing the retry logic to be skipped in these tests, the tests have been updated to properly test the retry logic in the client.