-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rosconsole echo #1324
Merged
Merged
Add rosconsole echo #1324
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2121b27
Add rosconsole echo
efernandez e30cf18
Change detail argument to verbose
efernandez 38d7d58
Remove explicit del call
efernandez 941e572
Use getattr instead of custom STRING_LEVEL
efernandez cbf04de
Simplify level_string_map init
efernandez 47e303b
Change level positional arg to flag
efernandez 8a0d767
Pre-compute level max length
efernandez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it would make sense to use
argparse
for the whole script. But I wouldn't couple that with the feature you are adding here. It is certainly good to use it for the newecho
verb.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean I should make it local to the function where it's being used?
I honestly don't think it makes a big difference, but I can do that if that's what you're requesting here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, for not being clearer. I wasn't referring to the location of the import statement. Instead I was trying to point out that the first command line argument of
rosconsole
is inspected "manually" by looking atsys.argv
and thenargparse
is only used for the newecho
verb. It would be nice ifargparse
would be used for all arguments including the decision/selection based on the verb.But that is clearly outside the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha! Yes, that makes a lot of sense, but definitely not a change for this PR.