fix various compiler warnings on bionic #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
force-pushed
the
fix_warning_on_bionic
branch
3 times, most recently
from
3106fba
to
2eddc4e
Compare
clalancette
reviewed
Feb 12, 2018
| @@ -132,7 +134,7 @@ TEST_F(Synchronous, readWhileWriting) | |||
| for (int i = 0; i < 10; ++i) | |||
| { | |||
| const uint32_t buf_size = 1024*1024; | |||
| std::auto_ptr<uint8_t> read_buf(new uint8_t[buf_size]); | |||
| boost::shared_ptr<uint8_t[]> read_buf(new uint8_t[buf_size]); | |||
There was a problem hiding this comment.
I know that ros_comm generally uses boost, but given that this is buried in a test, can we just use std::shared_ptr?
There was a problem hiding this comment.
Since the package isn't building with C++11 it can't use std smart pointers. And changing the C++ standard version was beyond the scope of this patch.
| @@ -457,7 +457,7 @@ TEST(XmpRpc, errors) { | |||
| EXPECT_FALSE(v); | |||
|
|
|||
| // Conversions to other types should now throw an XmlRpcException. | |||
| EXPECT_THROW((int)value, XmlRpcException); | |||
| EXPECT_THROW((void)(int)value; , XmlRpcException); | |||
There was a problem hiding this comment.
Is a semicolon supposed to be here?
There was a problem hiding this comment.
Thanks for catching this. It is a left over of a previously tried workaround. I removed it.
dirk-thomas
force-pushed
the
fix_warning_on_bionic
branch
5 times, most recently
from
79bd4b8
to
3cdff92
Compare
dirk-thomas
force-pushed
the
fix_warning_on_bionic
branch
from
3cdff92
to
a112ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://build.ros.org/view/Mdev/job/Mdev__ros_comm__ubuntu_bionic_amd64/2/warnings22Result/new/