roscpp/transport_tcp: enable poll event POLLRDHUP to detect dead #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connections properly
|
That look great! |
|
I can confirm that this fixes #1699 on Linux |
|
This might also fix the long standing #158 |
|
@dirk-thomas friendly ping.... could this please be merged? |
|
Thanks for the patch. |
This was referenced Aug 7, 2019
|
Hi, I'm on melodic on Ubuntu Bionic with ros-comm 1.14.3-0bionic.20191008.215948. I'm experiencing #158 (disconnect callback is invoked after long time). I understand this PR was merged after the 1.14.3 release, correct? If so, any idea when the next release (containing this fix) is due? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connections properly.
The poll event
POLLRDHUPis needed to detect half-closed connections (source). This is needed to avoid the delay reported in #1699.