[BACKPORT] roslaunch: Allow passing _TIMEOUT_SIGINT and _TIMEOUT_SIGTERM as parameters #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meters (ros#1937) * Added --sigint-timeout and --sigterm-timeout parameters. * Fixed propagating sigint- and sigterm-timeout to remote nodes. * Added tests for sigint- and sigterm-timeout. * Decrease CPU load of timeout tests. * roslaunch: readded DEFAULT_TIMEOUT_SIGINT and DEFAULT_TIMEOUT_SIGTERM * roslaunch: --sigint_timeout, --sigterm-timeout take floats now * Fixing int to float in docs for sigint_timeout and sigterm_timeout * Reduced flakyness of test_roslaunch_parent and test_nodeprocess * Migrate test/signal_logger.py to Python 3. * roslaunch: Better exception handling, undoing whitespace changes. * roslaunch: Fix whitespace. Co-authored-by: Christopher Wecht <christopher.wecht@student.kit.edu>
bergercookie
changed the title
|
@bergercookie sorry, I am not the maintainer of this repository anymore. |
|
Can I get some feedback on this please? This could be a quite useful feature to have in |
|
@mjcarroll @sloretz Could you please have a look at this backport? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #1937 to melodic.
I think this feature is super useful to have in earlier ROS1 versions as well
@dirk-thomas , I've just cherry-picked the corresponding commit from
noetic-devel. Let me know if this 's not the preferred way of backporting features tomelodic.