Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Remove python2 specific hack #2364

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[windows] Remove python2 specific hack #2364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions tools/roslaunch/env-hooks/10.roslaunch.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
REM roslaunch/env-hooks/10.roslaunch.bat

:: workaround Python 2 xmlrpc performance issue
:: https://stackoverflow.com/questions/2617615/slow-python-http-server-on-localhost
:: use IP address instead to avoid unnecessary DNS lookups.
if "%ROS_MASTER_URI%" == "" (
set ROS_MASTER_URI=http://127.0.0.1:11311
)

:: it is discourage to set ROS_IP and ROS_HOSTNAME at the same time.
if "%ROS_IP%" == "" (
if "%ROS_HOSTNAME%" == "" (
set ROS_IP=127.0.0.1
)
set ROS_MASTER_URI=http://localhost:11311
)