roscpp: Adding AsyncSpinner::canStart to check if a spinner can be started #377
Conversation
| return true; | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Please simplify the code:
return spinlock.owns_lock();
|
Corrections made. |
|
+1 |
| " a second AsyncSpinner with a custom callback" | ||
| " queue, but another AsyncSpinner already exists," | ||
| " so your custom callback queue will not be serviced" | ||
| " by this AsyncSpinner."); |
There was a problem hiding this comment.
This error message actually can't be this precise. It's possible that the other AsyncSpinner was created with a non-default callback queue, so not even the default queue will be serviced.
|
I've updated the warning message to better characterize the issue with starting two |
|
+1 Manually merged in e6f48a8 with a minor whitespace change. |
|
I will cherry-pick the change to the hydro-devel branch once it passed CI - you don't have to create a PR for that. |
Cool. Thanks, Dirk. |
|
CI passed: http://jenkins.ros.org/view/Idev/job/devel-indigo-ros_comm/24/ |
This adds the introspection described in #277
Should a PR also be made against hydro?