Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use ifaddrs on Android as it is not natively supported #518

Merged
merged 1 commit into from
Dec 10, 2014

Conversation

garyservin
Copy link
Contributor

No description provided.

@ros-pull-request-builder
Copy link
Member

Can one of the admins verify this patch?

@dirk-thomas
Copy link
Member

With this patch the allowed_hosts_ variable will not contain the IP addresses of the various network interfaces and therefore reject connections coming from those. Have you tested that this actually still works on Android with connections coming from other processes on the local host?

@dirk-thomas
Copy link
Member

@ros-pull-request-builder
Copy link
Member

Test passed.
Refer to this link for build results: http://jenkins.ros.org/job/_pull_request-indigo-ros_comm/143/

@garyservin
Copy link
Contributor Author

@dirk-thomas sorry for the delay.

I've tested running two nodes (talker and listener) on the same phone, running the master both on the phone and on the pc and they worked.

I've also tested running one node on the pc and one on the phone and they were able to communicate.

Is this what you meant?

dirk-thomas added a commit that referenced this pull request Dec 10, 2014
Do not use ifaddrs on Android as it is not natively supported
@dirk-thomas dirk-thomas merged commit 6cf09de into ros:indigo-devel Dec 10, 2014
rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017
Do not use ifaddrs on Android as it is not natively supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants