Pause playback for topics #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Start with topic-pausing enabled if --pause-topics is used. * Minor error message improvements.
|
Test passed. |
|
Test passed. |
|
Thanks! Squashed and merged: b7796fe |
|
It looks like this caused a regression: #620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a replacement for #569, targeting Indigo instead of Hydro.
It's @tdenewiler's patch, with a couple of my tweaks. The only substantial change I made was to start in topic-pausing mode if
--pause-topicsis given at the command line, because I found that to be more intuitive (as opposed to requiring the user to hittto go into that mode).I tested with a few different cases, found it to work as advertised, and not to have any obvious side-effects.
To @dirk-thomas to approve and merge.