-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix passing multiple args to add_rostest #791
Conversation
👍 Exactly the fix I was thinking of. I you give me a few minutes, I can checkout the code and give it a try. Not sure if the tests already check that. BTW, any chance this could get backported to indigo? |
Absolutely, please give it a try and yes, it will be backported since it is a clear bug fix. |
@dirk-thomas How can I test it? I've just checkout the repo on my workspace, but it still uses the system version. |
After cloning this branch into your workspace and building it other packages in the workspace will use the rostest package from the workspace hence the custom version. |
Ok, let me catkin clean && catkin build then (not just catkin build). |
Confirmed. It works. I tested directly with this branch on indigo, which works fine. I guess you'll cherry-pick the commit from this PR into indigo. I guess it'll work too, but please tag me on the PR against indigo if you want me to test it again. |
Thanks for testing it. Since the patch is straight forward I just cherry-picked it to indigo-devel: 7f251de |
Thanks for the extremely fast fix. |
@dirk-thomas When would the indigo-devel commit get into the next release? :) |
While the previous release is in shadow-fixed there are a couple of regressions. So I will likely create a new release in the next days and after a shorter soak time it will be synced (hopefully 😉). |
fix passing multiple args to add_rostest
Fixes #790.