Add logger roscpp_internal.connections. #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need more connection leve diagnostics in our logs but turning on DEBUG for roscpp_internal generates a flood of information. We only need visibility into when tcpros connections are created/dropped for publishers and subscribers. The rospy nodes currently do this but the roscpp ones do not. A DEBUG macro for logging messages to the named logger roscpp_internal.connections has been added. This will allow it to inherit the roscpp_internal log level or be turned on separately to just get connection-related messages.
|
+1 |
mikepurvis
added a commit
that referenced
this pull request
Feb 9, 2017
mikepurvis
added a commit
to clearpathrobotics/ros_comm
that referenced
this pull request
Feb 10, 2017
mikepurvis
added a commit
that referenced
this pull request
Feb 10, 2017
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
Add logger roscpp_internal.connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need more connection leve diagnostics in our logs but turning
on DEBUG for roscpp_internal generates a flood of information. We
only need visibility into when tcpros connections are created/dropped
for publishers and subscribers. The rospy nodes currently do this
but the roscpp ones do not.
A DEBUG macro for logging messages to the named logger
roscpp_internal.connections has been added. This will
allow it to inherit the roscpp_internal log level or be
turned on separately to just get connection-related messages.