Add in ros_python_version. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
8 tasks
dirk-thomas
reviewed
May 18, 2018
CMakeLists.txt
Outdated
| @@ -7,6 +7,13 @@ catkin_package() | |||
| set(ROS_VERSION "1") | |||
| set(ROS_DISTRO "melodic") | |||
|
|
|||
| set(ROS_PY_VER "$ENV{ROS_PYTHON_VERSION}") | |||
| if(ROS_PY_VER) | |||
| set(ROS_PYTHON_VERSION "${ROS_PY_VER}") | |||
There was a problem hiding this comment.
I would suggest to change this to the following to avoid the temporary variable:
if(DEFINED ENV{VAR})
set(ROS_PYTHON_VERSION "$ENV{ROS_PYTHON_VERSION}")
There was a problem hiding this comment.
Good call, done in ecffcd0
|
I think this should be added to REP 149 too. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Will do. |
johnsonshih
added a commit
to johnsonshih/ros_environment
that referenced
this pull request
Oct 4, 2018
dirk-thomas
pushed a commit
that referenced
this pull request
Jan 26, 2019
….em (#13) * Update env. hook batch file to set ros_package_path correctly (#1) * Get ROS_PACKAGE_PATH from the python (#2) * Get ROS_PACKAGE_PATH from the python * normcase workspace path and eliminate duplicate entries * Preserve the content from CMAKE_PREFIX_PATH and remove duplicate entries (#4) * use set to remove duplicate entries in a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org