Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use _WIN32 for platform detection #110

Merged
merged 1 commit into from
Jul 15, 2019
Merged

use _WIN32 for platform detection #110

merged 1 commit into from
Jul 15, 2019

Conversation

kejxu
Copy link
Contributor

@kejxu kejxu commented Jul 15, 2019

as discussed in #108, WIN32 is only introduced by windows.h, it is better to use _WIN32 defined by the Visual Studio compiler for platform detection

@dirk-thomas
Copy link
Member

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 7549340 into ros:kinetic-devel Jul 15, 2019
@kejxu kejxu deleted the win32_macro_update branch July 15, 2019 22:09
@dirk-thomas dirk-thomas mentioned this pull request Jul 15, 2019
Closed
@dirk-thomas dirk-thomas mentioned this pull request Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kejxu @dirk-thomas