Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libqwt-qt5-dev for ubuntu xenial #11593

Merged
merged 2 commits into from
Jun 2, 2016
Merged

add libqwt-qt5-dev for ubuntu xenial #11593

merged 2 commits into from
Jun 2, 2016

Conversation

samuelba
Copy link
Contributor

Rqt in Kinetic is based on QT5, this means rqt plugins using QWT must use the QT5 version of libqwt which is libqwt-qt5. Otherwise, a Segmentation fault (core dumped) occurs at the start of the rqt plugin.

gdb output:

Thread 1 "python" received signal SIGSEGV, Segmentation fault.
0x00007fffadb565a4 in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4

@tfoote
Copy link
Member

tfoote commented May 21, 2016

For Kinetic support please add rules for wily and jessie as well.

connected to #11488

@dirk-thomas
Copy link
Member

As far as I know there are no Python Qwt 6.1 packages available. So this won't make the plugins work.

@samuelba
Copy link
Contributor Author

at least C++ rqt plugins using qwt (like our rqt_multiplot) work with libqwt-qt5. I don't know about python rqt plugins. @dirk-thomas there is a python qwt implementation working with PyQt5 -> PythonQwt, however, I didn't test it.

@dirk-thomas
Copy link
Member

I was referring to an Ubuntu package which we could depend on. +1 foradding the C++ only entry (with the comments from @tfoote).

@samuelba
Copy link
Contributor Author

I added the qt5 rule for wily and the qt4 rules for utopic and vivid. However, the libqwt-qt5-dev doesn't exist on jessie, there seems to be a package for stretch but not for jessie.

@dirk-thomas
Copy link
Member

I already gave my +1 above. This is pending a second review from the @ros/ros_team.

@tfoote
Copy link
Member

tfoote commented Jun 1, 2016

For jessie then we should put in the older version https://packages.debian.org/jessie/libqwt-dev matching the older ubuntu distros.

@jacquelinekay
Copy link
Contributor

Wouldn't that mean that qt plugins on Jessie that use libqwt will segfault?

@tfoote
Copy link
Member

tfoote commented Jun 1, 2016

Yeah, I guess we could either create a separate rule for qt5 vs qt4 qwt or just leave it off for now. Or consider a backport into our repos. Otherwise we'll need to blacklist anything using this for debian.

@jacquelinekay
Copy link
Contributor

I'm ambivalent about Jessie since it's not one of our "core" platforms; I'll leave it up to Tully to decide what to do about that. +1 from me to add libqwt-qt5 to Xenial.

@tfoote
Copy link
Member

tfoote commented Jun 2, 2016

Ok, we'll go w/o the rule for now. Any package that depends on this will need to be blacklisted for debian jessie. If there's demand we can consider trying to generate a backport.

@tfoote tfoote merged commit 52d8f1b into ros:master Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants