-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libqwt-qt5-dev for ubuntu xenial #11593
Conversation
For Kinetic support please add rules for wily and jessie as well. connected to #11488 |
As far as I know there are no Python Qwt 6.1 packages available. So this won't make the plugins work. |
at least C++ rqt plugins using qwt (like our rqt_multiplot) work with libqwt-qt5. I don't know about python rqt plugins. @dirk-thomas there is a python qwt implementation working with PyQt5 -> PythonQwt, however, I didn't test it. |
I was referring to an Ubuntu package which we could depend on. +1 foradding the C++ only entry (with the comments from @tfoote). |
I added the qt5 rule for wily and the qt4 rules for utopic and vivid. However, the libqwt-qt5-dev doesn't exist on jessie, there seems to be a package for stretch but not for jessie. |
I already gave my +1 above. This is pending a second review from the @ros/ros_team. |
For jessie then we should put in the older version https://packages.debian.org/jessie/libqwt-dev matching the older ubuntu distros. |
Wouldn't that mean that qt plugins on Jessie that use libqwt will segfault? |
Yeah, I guess we could either create a separate rule for qt5 vs qt4 qwt or just leave it off for now. Or consider a backport into our repos. Otherwise we'll need to blacklist anything using this for debian. |
I'm ambivalent about Jessie since it's not one of our "core" platforms; I'll leave it up to Tully to decide what to do about that. +1 from me to add libqwt-qt5 to Xenial. |
Ok, we'll go w/o the rule for now. Any package that depends on this will need to be blacklisted for debian jessie. If there's demand we can consider trying to generate a backport. |
Rqt in Kinetic is based on QT5, this means rqt plugins using QWT must use the QT5 version of
libqwt
which islibqwt-qt5
. Otherwise, aSegmentation fault (core dumped)
occurs at the start of the rqt plugin.gdb output: