Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute rosdep rule for libgpgme11-dev #16229

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

jwon02
Copy link
Contributor

@jwon02 jwon02 commented Nov 1, 2017

Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libgpgme11-dev has been discontinued in ubuntu as of yakkety in favor of libgpgme-dev so we need to explicitly call out Ubuntu distributions, everything up to xenial should use libgpgme11-dev and yakkety and later will use libgpgme-dev.
Same for Debian: jessie and before will have libgpgme11-dev and stretch and later will use libgpgme-dev

@jwon02 jwon02 force-pushed the contribute_rule_for_libgpgme branch from 8e233bd to ebb65c2 Compare November 1, 2017 21:01
@jwon02
Copy link
Contributor Author

jwon02 commented Nov 1, 2017

Thank you @mikaelarguedas. Updated the PR as suggested.

@tfoote
Copy link
Member

tfoote commented Nov 1, 2017

Thanks @jwon02 for the quick update. Could you add ubuntu artful and bionic too since we're looking forward toward melodic already. (Note keep alphabetical order so they'll be at the top of the list.)

@mikaelarguedas mikaelarguedas dismissed their stale review November 1, 2017 21:14

pr updated, waiting to follow up changes before second review

@jwon02 jwon02 force-pushed the contribute_rule_for_libgpgme branch from ebb65c2 to 5f09482 Compare November 1, 2017 21:22
@jwon02
Copy link
Contributor Author

jwon02 commented Nov 1, 2017

Thank you @tfoote. Added artful and bionic. I also removed digits 11 from the key to have libgpgme-dev.

Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @jwon02 for the quick iteration

@tfoote tfoote merged commit c1dbef5 into ros:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants