Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change mapping of python-imaging since the package was removed from bionic #17157

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

dirk-thomas
Copy link
Member

To address the failing CI from ros/ros_comm#1350 as well as the now failing binary job (http://build.ros.org/view/Msrc_uB/job/Mbin_uB64__rosbag__ubuntu_bionic_amd64__binary/3/).

@mikaelarguedas
Copy link
Member

As python-pil is available on all Melodic targeted platforms, should we update the other ones ? maybe just artful as if doesn;'t share any platform with the other ROS distros ?

@dirk-thomas
Copy link
Member Author

Please feel free to propose related changes. I just want this specific change to get merged since it blocks building melodic packages.

I don't see why any other mapping needs to change though.

@mikaelarguedas
Copy link
Member

IDK it seems strange to target a different package for only one platform while the newly targeted package is available on all active Ubuntu and Debian distributions.
If you're confident that python-pil in bionic provides exactly the same behavior as python-imaging on other platforms and that using python-pil everywhere would break things I guess that's fine to merge as is

@dirk-thomas dirk-thomas merged commit 81cf393 into master Mar 16, 2018
@dirk-thomas dirk-thomas deleted the python-imaging-bionic branch March 16, 2018 19:14
@tfoote
Copy link
Member

tfoote commented Mar 16, 2018

Looking at python-imaging: https://packages.ubuntu.com/artful/python-imaging it appears to have just been a basic wrapper package that depends on python-pil for the full implementation.

python-pil has been available as far back as trusty: https://packages.ubuntu.com/artful/python-pil

We could consider switching all of the rules to python-pil but I think this is the more conservative approach without deeper research.

HEllRZA pushed a commit to HEllRZA/rosdistro that referenced this pull request Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants