-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rosdep: add Ignition Citadel #24934
rosdep: add Ignition Citadel #24934
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe these packages are available for older supported versions of Debian or Ubuntu.
I think these keys need to be rewritten so they're scoped to just focal and buster. e.g.
ignition-citadel:
debian:
buster: [ignition-citadel]
'*': null
ubuntu:
focal: [ignition-citadel]
'*': null
@nuclearsandwich does the |
No you're right. I had my wires crossed. the explicit null is used when they key is defined for most distributions but not one particular one. So the PR could either assume forward compatibility: keyname:
debian:
'*': [packagename]
jessie: null
stretch: null
ubuntu:
'*': [packagename]
bionic: null
xenial: null or not: keyname:
debian:
buster: [packagename]
ubuntu:
focal: [packagename] Given the fact that these packages are versioned and many of them are being imported directly not upstreamed I'd suggest the latter form. |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
done |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina it looks like there are some outstanding checks failing. Alphabetical ordering is at least part of it.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sorry for overlooking that, @nuclearsandwich . Updated in 73aa168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note for fellow reviewers: Not all of these packages are available upstream. Those that are not have been imported into the ROS buildfarm bootstrap repository directly (see ros-infrastructure/reprepro-updater#75)
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Some of these keys are already being used by the ros_ign packages to bloom it into https://packages.osrfoundation.org:
https://github.com/osrf/osrf-rosdep/blob/master/ignition/ignition.yaml
This is a follow up to #24646