-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python-modbus-pip to python.yaml #32010
Conversation
rosdep/python.yaml
Outdated
@@ -3694,6 +3694,13 @@ python-pymavlink: | |||
python-pymodbus: | |||
debian: [python-pymodbus] | |||
ubuntu: [python-pymodbus] | |||
python-pymodbus-pip: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change, since these are identical please make the python3-
key an alias to the python-
key.
python-pymodbus-pip: &migrate_eol_2027_04_30_python3_pymodbus_pip
debian:
pip:
packages: [pymodbus]
ubuntu:
pip:
packages: [pymodbus]
...
python3-pymodbus-pip: *migrate_eol_2027_04_30_python3_pymodbus_pip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will do! Quick question though: how do I determine the EOL? Or better, how did you determine it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do I determine the EOL? Or better, how did you determine it?
I know we're transitioning to Ubuntu Jammy for ROS Rolling at the moment, so I assumed both that it counts as a supported platform and that it has the furthest away EOL date of April 2027.
I could use a little help here. I am not sure why I am getting the following nosetest error:
and
|
To be more clear, this probably fixes the issue: python-pymodbus:
debian: [python-pymodbus]
ubuntu:
'*': [python-pymodbus]
jammy: null |
@ivanpauno thanks for the suggestion. Given the errors I received before I added both |
Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Please add the
python-modbus-pip
dependency to the rosdep database.Package name:
python-modbus-pip
Package Upstream Source:
Link to source repository: https://github.com/riptideio/pymodbus
Purpose of using this:
There already is an entry for
python-modbus
in the YAML. However, the Ubuntu and Debian repositories have outdated versions, 1.3.2 and 1.2.0 respectively.When installing from PyPI we get a more recent version - 2.5.3.
I suggest to keep the outdated
python-modbus
inside the YAML to not break compatibility.Distro packaging links:
Links to Distribution Packages