Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release repository url for acado_vendor. #32065

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

nuclearsandwich
Copy link
Member

This release repository was forked into ros2-gbp for the Galactic migration in April 2021 and has not been released into the upstream repository since.

Since the upcoming Rolling platform migration will again branch the release repository into ros2-gbp I recommend that we update it pre-emptively to reduce churn in the bloom configuration branches.

This release repository was forked into ros2-gbp for the Galactic
migration in April 2021 and has not been released into the upstream
repository since.

Since the upcoming Rolling platform migration will again branch the
release repository into ros2-gbp I recommend that we update it
pre-emptively to reduce churn in the bloom configuration branches.
@nuclearsandwich nuclearsandwich self-assigned this Feb 7, 2022
@nuclearsandwich
Copy link
Member Author

@JWhitleyWork FYI

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Feb 7, 2022
@wep21
Copy link
Contributor

wep21 commented Feb 7, 2022

@nuclearsandwich Could you also add tvm_vendor-release in autoware group of ros2-gbp? https://github.com/autowarefoundation/tvm_vendor
Thanks in advance!

@JWhitleyWork
Copy link
Contributor

@nuclearsandwich Does it make more sense to update the current release repo?

@nuclearsandwich
Copy link
Member Author

@nuclearsandwich Does it make more sense to update the current release repo?

It makes the most sense for the the ros2-gbp release repositories to be used for all ROS 2 distributions. The Rolling distribution will always need to maintain the ros2-gbp copy of the release repository so that migrations like this one can be run with a target repository that the automation can push to and future ROS 2 distributions created from Rolling will all start out with release repositories in the ros2-gbp organization.

@JWhitleyWork
Copy link
Contributor

@nuclearsandwich Thanks for the info! I'll try to go through and make sure all my covered repos have this set correctly (hopefully save you some time).

@nuclearsandwich
Copy link
Member Author

Thanks for the info! I'll try to go through and make sure all my covered repos have this set correctly (hopefully save you some time).

I'm grateful for the initiative. In general the current state of Rolling is frozen pending this transition so there will be aftermath no matter what. The repositories I worked on today were in a special case of already having a ros2-gbp release repository from a previous migration (usually the original creation of Galactic) but which weren't using that repository on Rolling.

There is a larger pool of repositories that are not currently hosted in ros2-gbp which will get a similar message after the migration.

@nuclearsandwich nuclearsandwich merged commit 019153a into master Feb 8, 2022
@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/acado_vendor-release branch February 8, 2022 01:25
@nuclearsandwich
Copy link
Member Author

@nuclearsandwich Could you also add tvm_vendor-release in autoware group of ros2-gbp? https://github.com/autowarefoundation/tvm_vendor
Thanks in advance!

Done in #32092

@wep21
Copy link
Contributor

wep21 commented Feb 8, 2022

@nuclearsandwich Thank you for creating the release repository.
Could you also invite @wep21 @kenji-miyake @mitsudome-r to autoware group in ros2-gbp?

@nuclearsandwich
Copy link
Member Author

@nuclearsandwich Thank you for creating the release repository.
Could you also invite @wep21 @kenji-miyake @mitsudome-r to autoware group in ros2-gbp?

I'm going to wait to handle this request since I'll be publishing a new mechanism that will allow me to better track them and keep them from being spread around in unrelated issues and pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants