Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rosdep keys used by noetic on Ubuntu 22.04 #33110

Merged
merged 7 commits into from
May 23, 2022
Merged

rosdep keys used by noetic on Ubuntu 22.04 #33110

merged 7 commits into from
May 23, 2022

Conversation

dreuter
Copy link
Contributor

@dreuter dreuter commented May 9, 2022

Please add the following dependency to the rosdep database.

Package name:

  • hddtemp
  • liborocos-kdl
  • libogre[-dev]

Package Upstream Source:

omitted since they are already present in the base.yml

Purpose of using this:

I am trying to build noetic on Ubuntu 22.04. This allows me to install the dependencies as stated in the "Installing from source" instructions.

Distro packaging links:

@dreuter dreuter requested a review from a team as a code owner May 9, 2022 16:22
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label May 9, 2022
methylDragon
methylDragon previously requested changes May 9, 2022
View reviewed changes
rosdep/base.yaml Outdated Show resolved Hide resolved
@methylDragon methylDragon added the changes requested Maintainers have asked for changes to the pull request label May 9, 2022
tfoote
tfoote requested changes May 9, 2022
View reviewed changes
rosdep/base.yaml Outdated Show resolved Hide resolved
rosdep/base.yaml Outdated Show resolved Hide resolved
tfoote
tfoote requested changes May 10, 2022
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. The libogre-dev rule needs one small update still.

rosdep/base.yaml Outdated Show resolved Hide resolved
@dreuter
Copy link
Contributor Author

dreuter commented May 11, 2022

Just as a heads up: When I rebuild from scratch today I noticed that rosdep was complaining about libfltk-dev (https://packages.ubuntu.com/jammy/libfltk1.3-dev) as well.
I have added it in a similar vain as libogre-dev, hope that is okay? I can also create a separate PR for this if you want :)

@dreuter dreuter requested a review from tfoote May 11, 2022 19:45
@nuclearsandwich
Copy link
Member

I can also create a separate PR for this if you want :)

In general more focused pull requests are always easier to review.

ivanpauno
ivanpauno approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tfoote
tfoote approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. It's great to get things more compact.

@tfoote tfoote dismissed methylDragon’s stale review May 20, 2022 22:06

Sorting issue resolved.

tfoote
tfoote reviewed May 20, 2022
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cottsay I'm not sure why this is failing outside of the changed section. Clearly this rule is incorrect, but it shouldn't be checking here for this PR.

Check failure on line 707 in rosdep/base.yaml

GitHub Actions
/ Nosetests (3.8)

rosdep/base.yaml#L707

Package 'libcurlpp-dev' could not be found for debian buster on amd64

@tfoote tfoote requested a review from cottsay May 20, 2022 22:24
@cottsay
Copy link
Member

cottsay commented May 20, 2022 •
edited
Loading

I'm not sure why this is failing outside of the changed section.

This misbehavior is described in #31439. In short, #33130 removed a line that wasn't passing the check, and when the test diffs the HEAD of this PR against origin/master, it sees the line as being added because the PR branch doesn't contain the change that removes the line.

Rebasing or merging from master into the HEAD of this PR will make the check pass.

@dreuter @nuclearsandwich
add libogre and libogre-dev for jammy
5a01ee1 
These are the only two rosdep keys that are missing to run `rosdep` on
`noetic` `desktop-full` on Ubuntu 22.04, as described in the
["Installing from source"](http://wiki.ros.org/noetic/Installation/Source)
tutorial.
@dreuter @nuclearsandwich
update liborocos-kdl for jammy
f3638c4 
On Ubuntu 22.04 only version 1.5 of `liborocos-kdl` is available, but
noetic seems to compile fine with this version.
@dreuter @nuclearsandwich
"disable" hddtemp on jammy
32b22ec 
On Ubuntu 22.04 `hddtemp` seems to be no longer released (See
[packages.ubuntu.com](https://packages.ubuntu.com/focal/hddtemp), there
is no link to jammy).

Therefore to not run into any issues when using `rosdep` I have disabled
the installation of `hddtemp` for Ubuntu 22.04.
@dreuter @nuclearsandwich
"disable" hddtemp by default
632c5e4 
Currently `hddtemp` is only available on `bionic`, `focal` and `impish`.
Since it is unclear whether it will be released in a future version of
Ubuntu the default will now be to disable `hddtemp` on all not
explicitly mentioned releases.
@dreuter @nuclearsandwich
make liborocos-kdl1.5 the default for liborocos-kdl
faccfd1 
Since `liborocos-kdl1.5` will also most likely be the right package in
Ubuntu `kinetic` we make this the default and explicitly mention
`focal` and `impish` for
[`liborocos-kdl1.4`](https://packages.ubuntu.com/focal/liborocos-kdl1.4).
@dreuter @nuclearsandwich
collapse ubuntu mapping for libogre[-dev]
171ebdb 
All releases of Ubuntu since xenial use the same package name for
`libogre[-dev]`, therefore we can collapse the mapping.
@dreuter @nuclearsandwich
collapse ubuntu mapping for libfltk-dev
890abdd 
All releases of Ubuntu since xenial use the same package name for
[`libfltk-dev`](https://packages.ubuntu.com/jammy/libfltk1.3-dev),
therefore we can collapse the mapping.
This has the added benefit that this key will also work on `jammy` and
`kinetic`.
@nuclearsandwich
Copy link
Member

Rebasing or merging from master into the HEAD of this PR will make the check pass.

@dreuter I took the liberty of pushing a rebase.

@dreuter
Copy link
Contributor Author

dreuter commented May 23, 2022

Rebasing or merging from master into the HEAD of this PR will make the check pass.

@dreuter I took the liberty of pushing a rebase.

Thank you very much :)

@nuclearsandwich nuclearsandwich merged commit 4f287cd into ros:master May 23, 2022
@dreuter dreuter deleted the noetic-jammy branch May 23, 2022 16:52
@pazeshun pazeshun mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon

@cottsay cottsay Awaiting requested review from cottsay

Assignees
No one assigned
Labels
changes requested Maintainers have asked for changes to the pull request rosdep Issue/PR is for a rosdep key
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dreuter @nuclearsandwich @cottsay @tfoote @methylDragon @ivanpauno