Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X Yosemite (10.10) Rosdep entires for python-vtk and libvtk-java #6227

Merged
merged 5 commits into from
Nov 10, 2014
Merged

OS X Yosemite (10.10) Rosdep entires for python-vtk and libvtk-java #6227

merged 5 commits into from
Nov 10, 2014

Conversation

JeremyCade
Copy link
Contributor

Clean install of ROS Indigo desktop full as per instructions fails during ros_pcl build due to the lack of mapping for libvtk-java and python-vtk (see Issues 4597).

libvtk is already mapped to the homebrew vtk package.

Adding lines for libvtk-java and python-vtk allows the installation to proceed without issue. Tested on MBP 2010, with Yosemite 10.10 with ROS Indigo.

@mikeferguson
Copy link
Contributor

+1 -- pcl_ros doesn't really need libvtk-java or python-vtk anyways, those were added to suppress a crazy number of CMake warnings.

@mikeferguson
Copy link
Contributor

See ros-perception/perception_pcl#44 for details.

python-vtk:
osx:
homebrew:
packages: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should just depend on libvtk because it brings in python support. Something like this:

python-vtk:
  osx:
    homebrew:
      packages: []
      depends: [libvtk]

@mikeferguson
Copy link
Contributor

+1 to wjwwood suggestion (I didn't even know you could do that in rosdistro)

@JeremyCade
Copy link
Contributor Author

Updated as per @wjwwood suggestion.

wjwwood added a commit that referenced this pull request Nov 10, 2014
OS X Yosemite (10.10) Rosdep entires for python-vtk and libvtk-java
@wjwwood wjwwood merged commit 7b49be8 into ros:master Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants