[kinetic] Replace 'rosdep' by 'rosdep-modules' #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobperron friendly ping |
jacobperron
reviewed
Dec 4, 2020
There was a problem hiding this comment.
Thanks for opening the PR. I'd rather keep the original commits from melodic-devel (cherry-picked), so I've opened #124 instead.
| <depend>boost</depend> | ||
| <depend>pkg-config</depend> | ||
| <depend condition="$ROS_PYTHON_VERSION == 2">python</depend> | ||
| <depend condition="$ROS_PYTHON_VERSION == 3">python</depend> |
There was a problem hiding this comment.
This should be python3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
Backport #109 to kinetic branch and also update the package manifest following the one at melodic-devel branch
Description:
I've noticed here that only ros-kinetic-core image from osrf dockerhub was automatically installing rosdep. Since that is not the desirable behavior anymore I'm backporting the #109 update to set the dependency against 'rosdep-modules'