Change some deps* function to public. #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 31, 2016
|
This can be considered for a future release of ROS. But since it changes ABI I don't think it should be merged into any of the existing ROS distributions. |
130s
force-pushed
the
j/move_somefuncs_public
branch
from
5e63e36
to
4895bb3
Compare
130s
added a commit
to 130s/rospack
that referenced
this pull request
Feb 25, 2017
Suggested code in ros#65, which changes existing methods signature, breaks ABI compatibility. Instead, this PR adds new methods that internally call existing methods, to keep ABI compatible.
130s
added a commit
to 130s/rospack
that referenced
this pull request
Feb 25, 2017
Suggested code in ros#65, which changes existing functions signature, breaks ABI compatibility. Instead, this PR adds new functions that internally call existing functions, to keep ABI compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosstackage::stackagecontains useful info, or at least it's more informative than just the package names that some publicdeps*functions provide as a result of them running. In some applications, being able to accessstackageobjects directly makes code much cleaner; otherwise we will have to manually obtain stackages by passing package names (, which is still feasible though).Is there any reason to not public-ize these functions? I thought it could be because we may not want to expose
stackagepublicly to the library users, but then I don't know why so.