Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle None as return value for call_pkg_config #8

Closed
wants to merge 2 commits into from
Closed

Handle None as return value for call_pkg_config #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
939d279
Handle None as return value for call_pkg_config
roehling Feb 22, 2013
9e242b1
More detailed error message for pkg-config failure
roehling Feb 22, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/rospack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,12 @@ Rosstackage::cpp_exports(const std::string& name, const std::string& type,
std::string errmsg = "could not call python function 'rosdep2.rospack.call_pkg_config'";
throw Exception(errmsg);
}
if(pValue == Py_None)
{
Py_DECREF(pValue);
std::string errmsg = "pkg-config failed for package '"+ (*it)->name_ +"' in python function 'rosdep2.rospack.call_pkg_config'";
throw Exception(errmsg);
}

flags.push_back(std::pair<std::string, bool>(PyString_AsString(pValue), true));
Py_DECREF(pValue);
Expand Down