Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address 2020 compatibility issues, relocate export menu item, and other items #106

Merged
merged 5 commits into from
Oct 16, 2020

Conversation

brawner
Copy link
Collaborator

@brawner brawner commented Oct 7, 2020

This addresses compatibility issues with SW 2020 as well as some minor improvements. It relocates the "Export as URDF" button to the "Tools" menu.

@jaytjoa
Copy link

jaytjoa commented Oct 8, 2020

Hi, the issue in the SOLIDWORKS 2020 is solved by using the exe in #105. Thank you for good support!

@mis-eu
Copy link

mis-eu commented Oct 13, 2020

Build error after applying this patch https://github.com//issues/105#issuecomment-704651739

Severity	Code	Description	Project	File	Line	Suppression State
Warning		Type library exporter warning processing 'SW2URDF.UI.IMessageBox.Show(#0), SW2URDF'. Warning: Non COM visible value type 'System.Windows.MessageBoxResult' is being referenced either from the type currently being exported or from one of its base types.	SW2URDF			
Warning		Type library exporter warning processing 'SW2URDF.UI.IMessageBox.Show(#0), SW2URDF'. Warning: Non COM visible value type 'System.Windows.MessageBoxResult' is being referenced either from the type currently being exported or from one of its base types.	SW2URDF			
Warning	CA1063	Provide an overridable implementation of Dispose(bool) on 'SWTestFixture' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources.	SW2URDF			Active
Warning		Registering an unsigned assembly with /codebase can cause your assembly to interfere with other applications that may be installed on the same computer. The /codebase switch is intended to be used only with signed assemblies. Please give your assembly a strong name and re-register it.	SW2URDF	C:\Users\Fiona\Desktop\solidworks_urdf_exporter\SW2URDF\RegAsm		
Warning	CA1816	Change 'SWTestFixture.Dispose()' to call 'GC.SuppressFinalize(object)'. This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.	SW2URDF	C:\Users\Fiona\Desktop\solidworks_urdf_exporter\SW2URDF\Test\SWTestFixture.cs	26	Active
Warning	CA1063	Modify 'SWTestFixture.Dispose()' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns.	SW2URDF	C:\Users\Fiona\Desktop\solidworks_urdf_exporter\SW2URDF\Test\SWTestFixture.cs	26	Active  

@brawner
Copy link
Collaborator Author

brawner commented Oct 13, 2020

@mis-eu I don't see an error, I just see warnings. Those warnings were present on my system so it looks like it succeeded for you!

@brawner brawner force-pushed the compatibility-2020 branch from 76df3f1 to 5ef0166 Compare October 16, 2020 23:18
@brawner brawner force-pushed the compatibility-2020 branch from 5ef0166 to c471a88 Compare October 16, 2020 23:22
@brawner brawner changed the title WIP: Address 2020 compatibility issues Address 2020 compatibility issues, relocate export menu item, and other items Oct 16, 2020
@brawner brawner merged commit dff1e0d into master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants