Skip to content

Fix a bug in graph query function and add regression test #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2022
Merged

Fix a bug in graph query function and add regression test #283

merged 1 commit into from
Oct 15, 2022

Conversation

@nnmm
Copy link
Contributor

@nnmm nnmm commented Oct 14, 2022

It's an easy mistake to make – in https://github.com/ros2/rcl/blob/rolling/rcl/include/rcl/graph.h, some functions have a no_demangle argument and others have a no_mangle argument. The no_mangle argument should be true, but it was false.

@nnmm nnmm requested a review from a team October 14, 2022 19:53
@christopherjreid
Copy link
Contributor

christopherjreid commented Oct 15, 2022

Whoops! :)

@nnmm nnmm merged commit 6954069 into main Oct 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_graph_query branch October 15, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esteve esteve esteve approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nnmm @christopherjreid @esteve